Re: 2.6.17-rc5-mm3-lockdep -

From: Herbert Xu
Date: Wed Jun 07 2006 - 03:12:18 EST


On Tue, Jun 06, 2006 at 04:39:21PM +0000, Stefan Richter wrote:
>
> BTW, the locking in -mm's net/unix/af_unix.c::unix_stream_connect()
> differs a bit from stock unix_stream_connect(). I see spin_lock_bh() in
> 2.6.17-rc5-mm3 where 2.6.17-rc5 has spin_lock().

Hi Ingo:

Looks like this change was introduced by the validator patch. Any idea
why this was done? AF_UNIX is a user-space-driven socket so there shouldn't
be any need for BH to be disabled there.

Even if it does this patch should go through the normal channels rather
than the lock validator.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/