Re: [PATCH 8/9] PCI PM: clear IO and MEM when disabling a device

[Adam Belay]

On Tue, 2006-06-06 at 10:32 +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2006-06-05 at 04:46 -0400, Adam Belay wrote:
> > This patch modifies pci_disable_device() to clear IO and MEM from the
> > COMMAND PCI config register.  This is required before entering D3,  but
> > also probably a good general practice for system suspend.
> 
> And will break a great deal of platforms. Don't do it :) The problem is,
> I think, mostly related to firmware issues.
> 
> Ben.

If the device must be enabled before passing control to firmware, then
shouldn't its controlling driver never call pci_disable_device()?  I'd
like to have pci_disable_device() actually disable devices, as this is
needed for D3.

Thanks,
Adam


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/