Re: [PATCH] fix missing hdlc symbols for synclink drivers

[Paul Fulghum]

On Wed, 2006-06-07 at 02:42 +0200, Krzysztof Halasa wrote:
> I don't know what special flexibility are you thinking about.
> DEPENDing on a symbol is as flexible and causes no such problems.
> The user just needs to enable (in this case) WAN and HDLC
> manually ((s)he has to select HDLC_* manually anyway). It could
> even make SYNCLINK_*_HDLC unneeded, the added functionality could
> (optionally) be selected automagically.

That is close to the way it was working, but it
had build errors with synclink=y and hdlc=m which
is what started all of these patches.

I guess I could add an extra check for that broken config
case in all the individual source files using conditional compilation
and disable synclink HDLC support altogether if such
a broken selection of options occurs (through
a random config generation). Still messy, but
since there seems to be a consensus that using the 'select'
facility of kbuild is forbidden, that may be the more
politically palatable way to go.

--
Paul


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/