Re: [PATCH] fix missing hdlc symbols for synclink drivers

[Randy.Dunlap]

On Wed, 07 Jun 2006 00:44:09 +0200 Krzysztof Halasa wrote:

> "Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> writes:
> 
> > OK, it's still not working.  As Dave Jones reported:
> >
> >> WARNING: /lib/modules/2.6.17-rc5-mm3/kernel/drivers/char/pcmcia/
> >>   synclink_cs.ko needs unknown symbol alloc_hdlcdev
> 
> Looks like the only patch in mm3 touching it is:
> fix-kbuild-dependencies-for-synclink-drivers.
> 
> BTW: selecting CONFIG_HDLC without selecting at least one protocol
> does nothing good (except that the thing actually builds). As I said,
> I'd rather let the user decide what it's needed.
> 
> Hmm, with 2.6.17-rc5-mm3 it builds fine here (~ up-to-date FC5, i386):
> 
> $ egrep '^C.*(SYNCLINK|HDLC)' .config
> CONFIG_HDLC=m
> CONFIG_SYNCLINK=m
> CONFIG_SYNCLINK_HDLC=y
> CONFIG_SYNCLINKMP=m
> CONFIG_SYNCLINKMP_HDLC=y
> CONFIG_SYNCLINK_GT=m
> CONFIG_SYNCLINK_GT_HDLC=y
> CONFIG_SYNCLINK_CS=m
> CONFIG_SYNCLINK_CS_HDLC=y
> 
> Are you sure it's not a corrupted build tree or something like that?
> Can I have a look at the complete .config? Or some other bugzilla #?

I did a make mrproper and got the same results.
I'm on x86-64 if it matters.
My .config is attached.

> There is exactly zero magic in generic HDLC, things are just build
> and exported as any other symbol in the tree.

Thanks for looking into this.
---
~Randy

Attachment: config-2617-rc5mm3-hdlc
Description: Binary data