Re: kbuild patch (20a468b51325b3636785a8ca0047ae514b39cbd5) breaks parallels-config

[Thomas Glanzmann]

Hello,

> First off - the below does not even remotely resemble a Kbuild file.
> There are a shitload of deinitions not used by kbuild etc etc.
> Parallels should ship a Kbuild file instead with the kernel specific
> things included and be done with it.  This works for others and they
> do not need to generate their Makefile using autotools.

agreed.

> What your patch did was to remove a fundamental part of the build system
> - and I'm suprised that you actually managed to build something.

my patch does not removes anything it just moves one line a few lines
down (as it was before your commit 20a468b51325b...:

        --- a/scripts/Makefile.build
        +++ b/scripts/Makefile.build
        @@ -10,12 +10,11 @@ __build:
         # Read .config if it exist, otherwise ignore
         -include .config
         
      | -include scripts/Kbuild.include
      | -
     /    # The filename Kbuild has precedence over Makefile
    /    kbuild-dir := $(if $(filter /%,$(src)),$(src),$(srctree)/$(src))
   |     include $(if $(wildcard $(kbuild-dir)/Kbuild), $(kbuild-dir)/Kbuild, $(kbuild-dir)/Makefile)
   \     
    `-> +include scripts/Kbuild.include
         include scripts/Makefile.lib
         
         ifdef host-progs

> I suggest that you ask the Parallels people to create a clean solution
> for the 2.6 kernel - seeking inspiration in Documentation/kbuild/*
> and when this works tweak it minimally to support the 2.4 kernel.

I will.

        Thomas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/