Re: [RFC][PATCH] request_irq(...,SA_BOOTMEM);

From: Andrew Morton
Date: Mon Jun 05 2006 - 04:56:12 EST


On Mon, 05 Jun 2006 18:49:36 +1000
Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:

> > And yes, the mutex code will (with debug enabled) unconditionally enable
> > interrupts. ppc64 tends to oops when this happens, in the timer handler
> > (so it'll be intermittent...)
>
> I tend to say that any code that hard-enables interrupts is looking for
> trouble (mostly for that very reason of init stuff).

Usually. But it's 100% daft to be preserving local irq state in
mutex_lock().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/