[patch, -rc5-mm2] genirq: handle_fasteoi_irq(): do not ->mask()

[Ingo Molnar]

Subject: genirq: handle_fasteoi_irq(): do not ->mask()
From: Ingo Molnar <mingo@xxxxxxx>

Ben noticed an inefficiency in the handle_fasteoi_irq() flow
handler: it does a spurious ->mask() call. (That call is not
needed - if something did a disable_irq() then it would have
masked the irq itself.)

i tested the fix on all affected fasteoi platforms: x86 and x86_64,
on both UP and SMP.

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
---
 kernel/irq/chip.c |    2 --
 1 file changed, 2 deletions(-)

Index: linux/kernel/irq/chip.c
===================================================================
--- linux.orig/kernel/irq/chip.c
+++ linux/kernel/irq/chip.c
@@ -324,8 +324,6 @@ handle_fasteoi_irq(unsigned int irq, str
 	spin_lock(&desc->lock);
 	desc->status &= ~IRQ_INPROGRESS;
 out:
-	if (unlikely(desc->status & IRQ_DISABLED))
-		desc->chip->mask(irq);
 	desc->chip->eoi(irq);
 
 	spin_unlock(&desc->lock);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/