Re: [PATCH] ipaq.c bugfixes

[Frank Gevaerts]

On Wed, May 31, 2006 at 03:46:24PM -0700, Greg KH wrote:
> On Thu, Jun 01, 2006 at 12:42:45AM +0200, Frank Gevaerts wrote:
> > +
> > +module_param(connect_retries, int, KP_RETRIES);
> 
> I really do not think that you want KP_RETRIES as a mode value in sysfs
> :)
> 
> This is not how you pre-initialize a module parameter...

Thanks. That should teach me not to try to fix kernel code without
reading documentation. I fixed it here, but I won't resubmit yet because
there are some 100% reproducible bugs left. 

Frank

> 
> thanks,
> 
> greg k-h

-- 
Frank Gevaerts                                 frank.gevaerts@xxxxxx
fks bvba - Formal and Knowledge Systems        http://www.fks.be/
Stationsstraat 108                             Tel:  ++32-(0)11-21 49 11
B-3570 ALKEN                                   Fax:  ++32-(0)11-22 04 19
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/