Re: [PATCH 7/11] 2.6.17-rc5 perfmon2 patch for review: modified i386 files

[Stephane Eranian]

On Wed, May 31, 2006 at 04:21:49PM +0200, Roman Zippel wrote:
> Hi,
> 
> On Wed, 31 May 2006, Stephane Eranian wrote:
> 
> > diff -ur linux-2.6.17-rc5.orig/arch/i386/Kconfig linux-2.6.17-rc5/arch/i386/Kconfig
> > --- linux-2.6.17-rc5.orig/arch/i386/Kconfig	2006-05-30 05:31:59.000000000 -0700
> > +++ linux-2.6.17-rc5/arch/i386/Kconfig	2006-05-30 02:48:12.000000000 -0700
> > @@ -763,6 +763,21 @@
> >  	  /sys/devices/system/cpu.
> >  
> >  
> > +menu "Hardware Performance Monitoring support"
> > +
> > +config PERFMON
> > +  	bool "Perfmon2 performance monitoring interface"
> > +	select X86_LOCAL_APIC
> > +	default y
> 
> Drop the defaults and I'm pretty sure you don't want to use select.
> 
What's wrong with 'default y' ?
Are you suggesting I use 'depends' instead of select?

Thanks.

-- 
-Stephane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/