Re: [PATCH] fix x86 microcode driver handling of multiplematching revisions

[Jan Beulich]

>> +		for_each_online_cpu(cpu_num) {
>> +			if (ucode_cpu_info[cpu_num].mc == uci->mc) {
>> +				uci->mc = NULL;
>> +				break;
>> +			}
>
>Isn't there a memory leak here? Shouldn't this be
>		for_each_online_cpu(cpu) {
>			if (cpu == cpu_num)
>				continue;
>			if (ucode_cpu_info[cpu].mc == uci->mc) {
>				uci->mc = NULL;
>				break;
>			}
>		}

Indeed, I'll send an updated patch later.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/