Re: [PATCH 2/2] ipg: redundancy with mii.h

From: Francois Romieu
Date: Thu May 04 2006 - 20:26:50 EST


David Vrabel <dvrabel@xxxxxxxxxx> :
[...]
> > ipg: replace #define with enum
> >
> > Added some underscores to improve readability.
> >
> > Signed-off-by: Francois Romieu <romieu@xxxxxxxxxxxxx>
>
> Nack. Register names in code should match those used in the
> documentation (even if they are a bit unreadable). Though I will
> conceed that the available datasheet doesn't actually describe the
> majority of the registers.

We will have to agree to disagree. Feel free to open a different
branch.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/