Re: Remove silly messages from input layer.

From: Hugh Dickins
Date: Thu May 04 2006 - 15:13:53 EST


On Thu, 4 May 2006, Dmitry Torokhov wrote:
> > > On Wed 03-05-06 22:44:04, Dave Jones wrote:
> > >
> > > >There are two messages in the input layer that seem to be
> > > >triggerable very easily, and they confuse end-users to no end.
> > > >"too many keys pressed? Should I press less keys?"
>
> Also I don't understand what people have against this message, it's at
> KERN_DEBUG level after all.

I often type at the text console; and I like to see KERN_DEBUG messages;
but I do NOT like to see kernel messages telling me I've mistyped - they
don't hurt my pride, but they do mess up my screen.

If I hit a wrong key, it's normal for that wrong key to be echoed, not a
kernel message saying "Are you sure you didn't want to hit another key?".
If I don't hit a key hard enough, it's normal for that key not to be
echoed. So why, if I happen to hit a combination of keys by mistake,
do I get that wretched "too many keys pressed" message? The appropriate
response is for what is accepted to be echoed, and that is all.

I keep #ifdef ATKBD_DEBUG around both the messages Dave highlighted
(but I forget when it was that I used to get the second one); the -mm
tree has had the "too many keys" message commented out for many months.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/