RE: [PATCH] MegaRAID driver management char device moved to misc

[Ju, Seokmann]

Hi,

> > > > So it now uses a misc device which I named "megadev0" (the
> > > > name that megarc
> > > > expects), and has a dynamic minor (previoulsy a dynamic major
> > > > was used).
> > > The driver can not change device node name for backward 
> > compatibility.
> > > I'm checking with application team inside for further 
> > clarification and update here.
> > 
> > That is an invalid reason: There was no hardcoded device node 
> > previously
> > (it was using a dynamically assigned major).
> You're right.
> I misunderstood the whole idea of creating device node.
> Besides this, I don't have any objection.
> I would accept the patch based on descriptoin in flowing link.
> http://www.us.kernel.org/pub/linux/utils/kernel/hotplug/udev_vs_devfs
I need take back previous comment for accepting the patch.
There are several applications that is running with the driver.
And those applications are need to be verified with this patch before merge it to up-stream.
I'm sorry for creating confusion, today.

I'll update my final comment on the patch once all necessary verifications have done.

Thank you, 

> -----Original Message-----
> From: Ju, Seokmann 
> Sent: Thursday, May 04, 2006 10:05 AM
> To: 'Thomas Horsten'
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Kolli, Neela; 
> linux-scsi@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH] MegaRAID driver management char device 
> moved to misc
> 
> Hi, 
> > > > So it now uses a misc device which I named "megadev0" (the
> > > > name that megarc
> > > > expects), and has a dynamic minor (previoulsy a dynamic major
> > > > was used).
> > > The driver can not change device node name for backward 
> > compatibility.
> > > I'm checking with application team inside for further 
> > clarification and update here.
> > 
> > That is an invalid reason: There was no hardcoded device node 
> > previously
> > (it was using a dynamically assigned major).
> You're right.
> I misunderstood the whole idea of creating device node.
> Besides this, I don't have any objection.
> I would accept the patch based on descriptoin in flowing link.
> http://www.us.kernel.org/pub/linux/utils/kernel/hotplug/udev_vs_devfs
> 
> Any other comment would be appreciated.
> 
> Thank you,
> 
> > -----Original Message-----
> > From: Thomas Horsten [mailto:thomas@xxxxxxxxxxx] 
> > Sent: Thursday, May 04, 2006 9:38 AM
> > To: Ju, Seokmann
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; Kolli, Neela; 
> > linux-scsi@xxxxxxxxxxxxxxx
> > Subject: RE: [PATCH] MegaRAID driver management char device 
> > moved to misc
> > 
> > On Thu, 4 May 2006, Ju, Seokmann wrote:
> > 
> > > Hi,
> > >
> > > For following reason, I cannot accept/approve this patch.
> > > I'll update further as I get clear.
> > >
> > > Thank you,
> > >
> > > > So it now uses a misc device which I named "megadev0" (the
> > > > name that megarc
> > > > expects), and has a dynamic minor (previoulsy a dynamic major
> > > > was used).
> > > The driver can not change device node name for backward 
> > compatibility.
> > > I'm checking with application team inside for further 
> > clarification and update here.
> > 
> > That is an invalid reason: There was no hardcoded device node 
> > previously
> > (it was using a dynamically assigned major).
> > 
> > The only tool I know which uses this device is "megarc" from 
> > LSI Logic.
> > This tool uses the char device /dev/megaraid0, which will be created
> > correctly when using my patch and udev (the recommended setup 
> > for Linux
> > 2.6 systems). I have tested this and it works.
> > 
> > User-level applications should not rely on hardcoded device 
> > numbers in any
> > case, but should use the correct device from /dev or search 
> > for the device
> > they need in sysfs.
> > 
> > Thomas
> > 
> > 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/