Re: [PATCH 6/13: eCryptfs] Superblock operations

[Pekka Enberg]

> On 5/4/06, Pavel Machek <pavel@xxxxxxx> wrote:
> > > +static int ecryptfs_statfs(struct super_block *sb, struct kstatfs *buf)
> > > +{
> > > +     int rc = 0;
> > > +
> > > +     ecryptfs_printk(KERN_DEBUG, "Enter\n");
> > > +     rc = vfs_statfs(ECRYPTFS_SUPERBLOCK_TO_LOWER(sb), buf);
> > > +     ecryptfs_printk(KERN_DEBUG, "Exit; rc = [%d]\n", rc);
> > > +     return rc;
> > > +}
> >
> > This is ugly. Could you remove the debugging, or at least use dprintk?

On 5/4/06, Michael Thompson <michael.craig.thompson@xxxxxxxxx> wrote:
> How would dprintk differ from the current approach with ecryptfs_printk?

Not much, so please just kill the function tracing stuffs. Thanks.

                                          Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/