Re: [PATCH -rt] scheduling while atomic in fs/file.c

From: Ingo Molnar
Date: Wed May 03 2006 - 16:39:54 EST



* Daniel Walker <dwalker@xxxxxxxxxx> wrote:

> - fddef = &get_cpu_var(fdtable_defer_list);
> + fddef = &__get_cpu_var(fdtable_defer_list);

ok, the bug you found is real - but i dont like the fix: now we will be
using smp_processor_id() in preemptible code, which will trip up under
DEBUG_PREEMPT. Since in this particular case any CPU is fine,
per_cpu(...,raw_smp_processor_id()) ought to do the trick. Mind to
update the patch?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/