Re: [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface

From: Greg KH
Date: Wed May 03 2006 - 13:45:08 EST


On Wed, May 03, 2006 at 03:18:56PM +0300, Razvan Gavril wrote:
> Greg KH wrote:
> >On Tue, May 02, 2006 at 12:32:57PM +0300, Razvan Gavril wrote:
> >
> >Care to diff this against 2.6.17-rc3? Lots of ftdi new device ids have
> >been added there.
> >
> >You also forgot to add a "Signed-off-by:" line :(
>
> Signed-Off By: Razvan Gavril <razvan.g@xxxxxxxxxxxxx>

Care to add a good text for what the patch does?

> ---
>
> diff -Nur linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c
> linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c
> --- linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c 2006-05-03
> 15:12:01.000000000 +0300

The patch is line wrapped :(

> +++ linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c 2006-05-03
> 15:04:39.000000000 +0300
> @@ -307,6 +307,7 @@
>
>
> static struct usb_device_id id_table_combined [] = {
> + { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },

And the tabs were stripped by your email client :(

Care to try again?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/