Re: [patch, 2.6.17-rc3-mm1] i386: break out of recursion in stackframe walk

[Ingo Molnar]

* Keith Owens <kaos@xxxxxxx> wrote:

> KDB just limits kernel traces to a maximum of 200 entries, which 
> catches direct as well as indirect recursion.  IA64 is notorious for 
> getting loops in its unwind data, sometime looping over three or four 
> functions.  Checking for a maximum number of entries is a simple and 
> architecture independent check.

you are right, but in this particular case this doesnt seem to be 
'wrong' unwind data, it's more of a special marker of the end of the 
frame (if i understood it correctly). If it's wrong unwind data then 
that data should be fixed.

I also agree with adding a limit to catch buggy cases of recursion, as a 
separate mechanism, independently of this particular bug.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/