Re: better leve triggered IRQ management needed

[Linus Torvalds]

On Tue, 2 May 2006, Neil Brown wrote:
> 
> Maybe the eisa_set_level_irq should be passed 'irq' rather than 'newirq' 
> ??

Yeah, stupid cut-and-paste error (the eisa_set_level_irq() call _is_ 
already there in the PCI irq setting, for the case where we actually have 
to set up routing that didn't exist before).

That's also why I'm a bit nervous even about my stupid one-liner patch: if 
the irq routing is already set up, and we just use the irq we're told to 
use, I'm not sure we should touch ELCR even if it "looks wrong". It 
obviously works on your machine, but I wonder what could break on others..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/