Re: [PATCH] RTC: rtc-dev UIE emulation

[Atsushi Nemoto]

Thanks for your detailed review, Andrew.  Basically I just merged
genrtc's stuff, but obviously it seems there are lots of things to
fix/refine/improve.  I'll try to do but it will take some times.

Alessandro, following comments are against for this patch, right?

On Sat, 29 Apr 2006 09:31:08 +0200, Alessandro Zummo <alessandro.zummo@xxxxxxxxxxxx> wrote:
>   this patch will conflict with rtc drivers that have proper UIE
>  support, please remove it from the tree.
> 
>   A generic UIE emulation should at least check if the ioctl
>  has not been already handled by the underlaying rtc driver.
> 
>   That means that every driver should be modified to return
>  -ENOIOCTLCMD if it gets passed an unknown IOCTL and that
>  this patch should check for this code before trying to emulate.

Since rtc_dev_ioctl() calls underlaying rtc driver's ioctl() first and
checks -EINVAL, so I think it will not conflict.  Is it wrong?

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/