Re: [PATCH] RTC: rtc-dev tweak for 64-bit kernel

[Andrew Morton]

Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:
>
> Make rtc-dev more friendly to 64-bit platforms with 32-bit userland.
> This tweak is came from genrtc driver.

Please define "friendly".  It's not clear what this patch does...

> Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
> 
> diff --git a/drivers/rtc/rtc-dev.c b/drivers/rtc/rtc-dev.c
> index b1e3e61..ae6adc4 100644
> --- a/drivers/rtc/rtc-dev.c
> +++ b/drivers/rtc/rtc-dev.c
> @@ -58,7 +58,7 @@ rtc_dev_read(struct file *file, char __u
>  	unsigned long data;
>  	ssize_t ret;
>  
> -	if (count < sizeof(unsigned long))
> +	if (count != sizeof (unsigned int) && count < sizeof (unsigned long))

We normally omit the space between "sizeof" and "(".

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/