Re: [PATCH] s390: Hypervisor File System

[Jörn Engel]

On Fri, 28 April 2006 19:37:08 +0200, Michael Holzheu wrote:
>  
> +static void *diag204_get_buffer(enum diag204_format fmt, int *pages)
> +{
> +	void *buf;
> +
> +	if (fmt == INFO_SIMPLE)
> +		*pages = 1;
> +	else
> +		*pages = diag204(SUBC_RSI | fmt, 0, 0);
> +
> +	if (*pages <= 0)
> +		return ERR_PTR(-ENOSYS);

Is -ENOSYS the right thing here?  I thought it was for stuff not
implemented by Linux.  If the hardware or some hypervisor would return
-ENOSYS, it would be -EIO from Linux' perspective.  But I may be
wrong.

Jörn

-- 
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/