Re: [PATCH] [3/4] i386: Fix overflow in e820_all_mapped

[Linus Torvalds]

On Fri, 28 Apr 2006, Andi Kleen wrote:
> 
> Quoting jbeulich:
>
> The effect is not on the current user's parameter passing, but in the 
> result the function may produce. If, say, for the PCI mmconfig and BIOS 
> space, there is a (reserved) entry starting at E0000000 and being 
> 20000000 in size, then as far as I can tell the function will return 
> zero (rather than one).

Well, but that has nothing to do with the _calling_ convention.

That looks to be a totally internal bug to within e820_all_mapped().

I agree that the calling convention change would avoid the overflow 
internally too, I just don't much like the explanation (and not 
necessarily that it affects the caller, who doesn't much care).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/