Re: [PATCH] s390: Hypervisor File System

[Michael Holzheu]

Pekka J Enberg <penberg@xxxxxxxxxxxxxx> wrote on 04/28/2006 12:36:59 PM:
>
> > +static struct dentry *update_file_dentry;
> > +static struct file_operations hypfs_file_ops;
> > +static struct file_system_type hypfs_type;
> > +static struct super_operations hypfs_s_ops;
> > +static time_t last_update_time = 0;   /* update time in seconds
> since 1970 */
> > +static DEFINE_MUTEX(hypfs_lock);
>
> These should be per-superblock and not global, right?

Yes! update_file_dentry, last_update_time and hypfs_lock
should be per-superblock. I will change this!

hypfs_file_ops, hpyfs_type and hypfs_s_ops should remain
global, since this will be the same for all super blocks.

Michael

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/