Re: i386 and PAE: pud_present()

From: Andi Kleen
Date: Fri Apr 28 2006 - 04:27:08 EST


On Friday 28 April 2006 09:54, Nick Piggin wrote:
> Magnus Damm wrote:
> > Hi guys,
> >
> > In file include/asm-i386/pgtable-3level.h:
> >
> > On i386 with PAE enabled, shouldn't pud_present() return (pud_val(pud)
> > & _PAGE_PRESENT) instead of constant 1?
> >
> > Today pud_present() returns constant 1 regardless of PAE or not. This
> > looks wrong to me, but maybe I'm misunderstanding how to fold the page
> > tables... =)
>
> Take a look a little further down the page for the comment.
>
> In i386 + PAE, pud is always present.

I think his problem is that the PGD is always present too (in pgtables-nopud.h)
Indeed looks strange.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/