Re: [PATCH] x86/PAE: Fix pte_clear for the >4GB RAM case

[Chris Wright]

* Andi Kleen (ak@xxxxxxx) wrote:
> > +static inline void pmd_clear(pmd_t *pmd)
> > +{
> > +	u32 *tmp = (u32 *)pmd;
> > +	*tmp = 0;
> > +	smp_wmb();
> > +	*(tmp + 1) = 0;
> > +}
> 
> I think that's still wrong - it should be wmb() not smp_wmb because this
> problem can happen on a UP kernel already.

I thought the barrier is to keep compiler from reordering not processor.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/