Re: [PATCH] -mm: i386 i8259.c simplify i8259A_irq_real()

[Andrew Morton]

Andreas Mohr <andi@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Hello all,
> 
> I noticed the very "non-nice" asymmetry of i8259A_irq_real(),
> so I decided to fix the weirdly aligned branches.
> While doing this, I noticed that it could be streamlined much more,
> resulting in an astonishing 208 byte object code saving for such a tiny code
> fragment! (gcc 3.2.3)

It saves an astonishing two bytes here, with gcc-3.2.1

   text    data     bss     dec     hex filename
   1302     388      10    1700     6a4 arch/i386/kernel/i8259.o

   1300     388      10    1698     6a2 arch/i386/kernel/i8259.o

;)



And with gcc-4.2.0:

bix:/usr/src/25> size arch/i386/kernel/i8259.o
   text    data     bss     dec     hex filename
   1340     356      12    1708     6ac arch/i386/kernel/i8259.o

   1335     356      12    1703     6a7 arch/i386/kernel/i8259.o


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/