Re: [RFC: 2.6 patch] fs/read_write.c: unexport iov_shorten

[Arjan van de Ven]

On Thu, 2006-04-27 at 11:52 -0700, Badari Pulavarty wrote:
> On Thu, 2006-04-27 at 20:03 +0200, Adrian Bunk wrote:
> > This patch removes the unused EXPORT_SYMBOL(iov_shorten).
> > 
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> > 
> > ---
> > 
> > This patch was already sent on:
> > - 23 Apr 2006
> > 
> > --- linux-2.6.17-rc1-mm3-full/fs/read_write.c.old	2006-04-23 15:51:52.000000000 +0200
> > +++ linux-2.6.17-rc1-mm3-full/fs/read_write.c	2006-04-23 15:52:02.000000000 +0200
> > @@ -436,8 +436,6 @@
> >  	return seg;
> >  }
> >  
> > -EXPORT_SYMBOL(iov_shorten);
> > -
> >  /* A write operation does a read from user space and vice versa */
> >  #define vrfy_dir(type) ((type) == READ ? VERIFY_WRITE : VERIFY_READ)
> >  
> 
> How about this ? Wondering if we need to make this "inline" also (since
> its used only in one place).


no real need; if it's static modern gcc will inline it anyway

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/