Re: [PATCH 1/6] iSER's Makefile and Kconfig

[Jan-Benedict Glaw]

On Thu, 2006-04-27 15:30:32 +0300, Or Gerlitz <ogerlitz@xxxxxxxxxxxx> wrote:
> Signed-off-by: Or Gerlitz <ogerlitz@xxxxxxxxxxxx>
> 
> --- /usr/src/linux-2.6.17-rc3/drivers/infiniband/ulp/iser-x/Makefile	1970-01-01 02:00:00.000000000 +0200
> +++ /usr/src/linux-2.6.17-rc3/drivers/infiniband/ulp/iser/Makefile	2006-04-27 15:12:33.000000000 +0300
> @@ -0,0 +1,6 @@
> +obj-$(CONFIG_INFINIBAND_ISER)	+= ib_iser.o
> +
> +ib_iser-y			:= iser_verbs.o \
> +				   iser_initiator.o \
> +				   iser_memory.o \
> +				   iscsi_iser.o 
> --- /usr/src/linux-2.6.17-rc3/drivers/infiniband/ulp/iser-x/Kconfig	1970-01-01 02:00:00.000000000 +0200
> +++ /usr/src/linux-2.6.17-rc3/drivers/infiniband/ulp/iser/Kconfig	2006-04-16 11:04:42.000000000 +0300
> @@ -0,0 +1,12 @@
> +config INFINIBAND_ISER
> +	tristate "ISCSI RDMA Protocol"
> +	depends on INFINIBAND && SCSI
> +	select SCSI_ISCSI_ATTRS
> +	---help---
> +
> +	  Support for the ISCSI RDMA Protocol over InfiniBand.  This
> +	  allows you to access storage devices that speak ISER/ISCSI
> +	  over InfiniBand.
> +
> +	  The ISER protocol is defined by IETF.
> +	  See <http://www.ietf.org/>.

Please always send patches in an order so that the kernel still is
compilable.

Eg. with your first patch introducing the Makefile stuff (while the C
files are still not there), this will break and thus make it harder to
automatically trace down unrelated breakages.

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@xxxxxxxxxx    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fÃr einen Freien Staat voll Freier BÃrger"  | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature