Re: [Ext2-devel] [UPDATE][14/21]e2fsprogs modify variables to exceed 2G

From: sho
Date: Thu Apr 27 2006 - 03:31:59 EST


Thanks for your comment, Andreas

On Apr 26, 2006, Andreas wrote:
> > + blk64_t end, save_blocks_count, i;
> > + (EXT2_BLOCKS_PER_GROUP(fs->super) *
> (__u64)fs->group_desc_count) - 1;
> > + blk64_t start_blk, last_blk;
> > + last_blk = (__u64) group_blk +
> fs->super->s_blocks_per_group - 1;
> >
> > + start_blk = (__u64) group_blk +
> fs->inode_blocks_per_group;
>
> If a variable is declared as blk64_t it should be cast to
> (blk64_t) instead of (__u64) I think.

I see your point. I checked the whole patches, and found other places.
And now I resend 4 update-patches.

Cheers, sho
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/