Re: [patch] RCU: introduce rcu_soon_pending() interface

[Paul E. McKenney]

On Tue, Apr 25, 2006 at 01:52:26PM +0200, Heiko Carstens wrote:
> > OK, got a look at your patch.
> > 
> > You are using this internally, as part of the RCU -implementation-.
> > You are determining whether this CPU will still be needed by RCU,
> > or whether it can be turned off.  So how 'bout calling the (internal)
> > API something like rcu_needs_cpu()?
> > 
> > int rcu_needs_cpu(int cpu)
> > {
> > 	struct rcu_data *rdp = &per_cpu(rcu_data, cpu);
> > 	struct rcu_data *rdp_bh = &per_cpu(rcu_bh_data, cpu);
> > 
> > 	return (!!rdp->curlist || !!rdp_bh->curlist || rcu_pending(cpu));
> > }
> > 
> > Then you can drop the rcu_pending() check from your 390 patch.
> > 
> > Seem reasonable?
> 
> Looks fine to me! Will you post a patch or should I?

Given that I am getting 24Kbps right now, could you please post it?

							Thanx, Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/