Re: [PATCH] reverse pci config space restore order

[Arjan van de Ven]

On Tue, 2006-04-25 at 11:48 +0100, Matthew Garrett wrote:
> On Tue, Apr 25, 2006 at 02:50:57PM +0800, Yu, Luming wrote:
> 
> > -	for (i = 0; i < 16; i++)
> > +	for (i = 15; i >= 0 ; i--)
> 
> We certainly need to do /something/ here, but I'm not sure this is it. 
> Adam Belay has code to limit PCI state restoration to the PCI-specified 
> registers, with the idea being that individual drivers fix things up 
> properly. While this has the obvious drawback that almost every PCI 
> driver in the tree would then need fixing up, it's also probably the 
> right thing.

it has a second drawback: it assumes all devices HAVE a driver, which
isn't normally the case...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/