Re: better leve triggered IRQ management needed

[Linus Torvalds]

On Mon, 24 Apr 2006, Russell King wrote:

> On Mon, Apr 24, 2006 at 12:02:47PM -0700, Linus Torvalds wrote:
> > On Mon, 24 Apr 2006, Stephen Hemminger wrote:
> > > We should fail request_irq() if the SA_SHIRQ but the irq is edge-triggered.
> > 
> > That would be HORRIBLE.
> > 
> > Edge-triggered works perfectly fine for SA_SHIRQ, as long as there is just 
> > one user and the driver is properly written. Making request_irq() fail 
> > would break existing and working setups.
> 
> Sorry, untrue.  If you take a serial port and a network card on the same
> edge triggered interrupt line [ ... ]

Read what I wrote!

	"..as long as there is just one user .."

In other words, you MUST NOT disallow request_irq(), just because the one 
user happens to use SA_SHIRQ.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/