Re: PCI ROM resource allocation issue with 2.6.17-rc2

[Linus Torvalds]

On Mon, 24 Apr 2006, Arjan van de Ven wrote:
> 
> you haven't spent enough time reading the X pci code then ;)
> (or rather, you've done the same thing but hey who's counting)
> 
> X does all that *itself* based on what X thinks is best.

Yeah, I knew that used to be true, but I was hoping the new interfaces 
would have made it obsolete. Especially as the DRM layer _does_ now enable 
the device on demand.

Maybe just add a DRM command to do it, so that old X versions (who don't 
know about it) will just do it by hand, and then new X versions can do

	if (drm_ioctl(fd, DRM_SETUP_THE_DAMN_RESOURCES) < 0) {
		/*
		 * I don't know what errno the drm-ioctl actually
		 * returns for unrecognized commands, so this is
		 * just an example
		 */
		if (errno == ENOTTY) {
			old kernel: do it by hand
		}
	}

which allows us to go forward in a sane way, and finally leave the broken 
X PCI-configuration-by-hand crap behind.

Please?

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/