Re: PCI ROM resource allocation issue with 2.6.17-rc2

From: Linus Torvalds
Date: Mon Apr 24 2006 - 13:07:58 EST




On Mon, 24 Apr 2006, Dave Airlie wrote:
>
> however not doing pci_enable_device causes interrupts to not work on the cards
> in a lot of circumstances..

Well, you could use "pci_enable_device_bars(0)" instead.

That will set up interrupt routing _without_ enabling any BAR's, however,
that's probably crazy too, since that means that if an interrupt happens,
you're really really screwed and can't do anything about it. So that's
probably even more broken than what you do now.

How about delaying the "pci_enable_device()" until when you actually need
it, ie do it in drm_irq_install() instead?

Of course, I wonder how you could POST the device without having the BAR's
enabled, and I sure as hell wouldn't want the POST sequence to decide
where to put them, since it has no clue what is allocated..

Sounds like X is being really bogus again.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/