[RFC: 2.6 patch] kernel/kthread.c: make kthread_stop_sem() static

From: Adrian Bunk
Date: Sun Apr 23 2006 - 07:40:17 EST


This patch makes the needlessly global kthread_stop_sem() static.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

---

include/linux/kthread.h | 12 ------------
kernel/kthread.c | 26 +++++++++++++++++---------
2 files changed, 17 insertions(+), 21 deletions(-)

--- linux-2.6.17-rc1-mm3-full/include/linux/kthread.h.old 2006-04-23 01:32:40.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/include/linux/kthread.h 2006-04-23 01:33:20.000000000 +0200
@@ -70,18 +70,6 @@
int kthread_stop(struct task_struct *k);

/**
- * kthread_stop_sem: stop a thread created by kthread_create().
- * @k: thread created by kthread_create().
- * @s: semaphore that @k waits on while idle.
- *
- * Does essentially the same thing as kthread_stop() above, but wakes
- * @k by calling up(@s).
- *
- * Returns the result of threadfn(), or -EINTR if wake_up_process()
- * was never called. */
-int kthread_stop_sem(struct task_struct *k, struct semaphore *s);
-
-/**
* kthread_should_stop: should this kthread return now?
*
* When someone calls kthread_stop on your kthread, it will be woken
--- linux-2.6.17-rc1-mm3-full/kernel/kthread.c.old 2006-04-23 01:30:48.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/kernel/kthread.c 2006-04-23 01:33:11.000000000 +0200
@@ -164,15 +164,18 @@
set_task_cpu(k, cpu);
k->cpus_allowed = cpumask_of_cpu(cpu);
}
-EXPORT_SYMBOL(kthread_bind);

-int kthread_stop(struct task_struct *k)
-{
- return kthread_stop_sem(k, NULL);
-}
-EXPORT_SYMBOL(kthread_stop);
-
-int kthread_stop_sem(struct task_struct *k, struct semaphore *s)
+/**
+ * kthread_stop_sem: stop a thread created by kthread_create().
+ * @k: thread created by kthread_create().
+ * @s: semaphore that @k waits on while idle.
+ *
+ * Does essentially the same thing as kthread_stop() above, but wakes
+ * @k by calling up(@s).
+ *
+ * Returns the result of threadfn(), or -EINTR if wake_up_process()
+ * was never called. */
+static int kthread_stop_sem(struct task_struct *k, struct semaphore *s)
{
int ret;

@@ -201,7 +204,12 @@

return ret;
}
-EXPORT_SYMBOL(kthread_stop_sem);
+
+int kthread_stop(struct task_struct *k)
+{
+ return kthread_stop_sem(k, NULL);
+}
+EXPORT_SYMBOL(kthread_stop);

static __init int helper_init(void)
{

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/