Re: [RFC][PATCH 5/9] CPU controller - Documents how the controllerworks

From: Mike Galbraith
Date: Sun Apr 23 2006 - 03:12:54 EST


On Fri, 2006-04-21 at 11:27 +0900, maeda.naoaki@xxxxxxxxxxxxxx wrote:
> +3. Timeslice scaling
> +
> + If there are hungry classes, we need to adjust timeslices to satisfy
> + the share. To scale timeslices, we introduce a scaling factor
> + used for scaling timeslices. The scaling factor is associated with
> + the class (stored in the cpu_rc structure) and adaptively adjusted
> + according to the class load and the share.

This all works fine until interactive task requeueing is considered, and
it must be considered.

One simple way to address the requeue problem is to introduce a scaled
class sleep_avg consumption factor. Remove the scaling exemption for
TASK_INTERACTIVE(p), and if a class's cpu usage doesn't drop to what is
expected by group timeslice scaling, make members consume sleep_avg at a
higher rate such that scaling can take effect.

A better way to achieve the desired group cpu usage IMHO would be to
adjust nice level of members at slice refresh time. This way, you get
the timeslice scaling and priority adjustment all in one.

(I think I would do both actually, with nice level being preferred such
that dynamic priority spread within the group isn't flattened, which can
cause terminal starvation within the group, unless really required.)

-Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/