Re: [PATCH] sound: fix hang in mpu401_uart.c

[Takashi Iwai]

At Wed, 19 Apr 2006 00:45:14 +0100,
Jon Masters wrote:
> 
> On 4/18/06, Takashi Iwai <tiwai@xxxxxxx> wrote:
> 
> > > +             if ((err = snd_mpu401_uart_cmd(mpu, MPU401_RESET, 1))) {
> > > +                     return -EFAULT;
> >
> > IMO, -EFAULT isn't a good choice for this kind of error.
> 
> What would you suggest?

I would use -EIO.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/