Re: [Linux-fbdev-devel] [2.6 patch] fix section mismatch in pm2fb.o

From: Randy.Dunlap
Date: Tue Apr 18 2006 - 21:06:51 EST


On Wed, 19 Apr 2006 01:50:38 +0200 Adrian Bunk wrote:

> From: Darren Jenkins <darrenrjenkins@xxxxxxxxx>
>
> There are a couple of Section mismatch problems in drivers/video/pm2fb.o
>
> WARNING: drivers/video/pm2fb.o - Section mismatch: reference
> to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd5d)
> WARNING: drivers/video/pm2fb.o - Section mismatch: reference
> to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd82)
>
> They are caused because pm2fb_set_par() uses lowhsync and lowvsync which
> are marked __devinitdata.
>
> This patch simply removes the __devinitdata annotations.
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@xxxxxxxxx>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> ---
>
> This patch was already sent on:
> - 9 Apr 2006
>
> --- 2.6.16-git20/drivers/video/pm2fb.c.orig 2006-04-03 19:08:51.000000000 +1000
> +++ 2.6.16-git20/drivers/video/pm2fb.c 2006-04-03 19:09:34.000000000 +1000
> @@ -73,8 +73,8 @@ static char *mode __devinitdata = NULL;
> * these flags allow the user to specify that requests for +ve sync
> * should be silently turned in -ve sync.
> */
> -static int lowhsync __devinitdata = 0;
> -static int lowvsync __devinitdata = 0;
> +static int lowhsync = 0;
> +static int lowvsync = 0;
>
> /*
> * The hardware state of the graphics card that isn't part of the

I'll ack that since I've already posted it to linux-fbdev-devel
and it's been acked there.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/