Re: [PATCH] Kernel doesn't compile with CONFIG_HOTPLUG && !CONFIG_NET

[Greg KH]

On Tue, Apr 18, 2006 at 04:16:14PM -0700, Andrew Morton wrote:
> Nigel Cunningham <ncunningham@xxxxxxxxxxxx> wrote:
> >
> > --- 9904.patch-old/kernel/sysctl.c	2006-04-19 08:40:47.000000000 +1000
> > +++ 9904.patch-new/kernel/sysctl.c	2006-04-17 21:06:23.000000000 +1000
> > @@ -401,7 +401,7 @@ static ctl_table kern_table[] = {
> >  		.strategy	= &sysctl_string,
> >  	},
> >  #endif
> > -#ifdef CONFIG_HOTPLUG
> > +#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)
> 
> I've had this in -mm for a couple of weeks now but rmk points out that it's
> rather silly.  Because if you have CONFIG_HOTPLUG=y, CONFIG_NET=n then the
> kernel cannot deliver hotplug events to userspace..
> 
> So perhaps CONFIG_HOTPLUG should depend upon CONFIG_NET or, better,
> CONFIG_NETLINK.

I have a patch in the queue from Kay that should fix this.  Hopefully...
Will get to it tomorrow.

> Dunno.  I left this in Greg's lap, but he's hiding.

Hiding?  A -stable release a day sure isn't hiding :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/