Re: [PATCH] Kernel doesn't compile with CONFIG_HOTPLUG &&!CONFIG_NET

[Andrew Morton]

Nigel Cunningham <ncunningham@xxxxxxxxxxxx> wrote:
>
> --- 9904.patch-old/kernel/sysctl.c	2006-04-19 08:40:47.000000000 +1000
> +++ 9904.patch-new/kernel/sysctl.c	2006-04-17 21:06:23.000000000 +1000
> @@ -401,7 +401,7 @@ static ctl_table kern_table[] = {
>  		.strategy	= &sysctl_string,
>  	},
>  #endif
> -#ifdef CONFIG_HOTPLUG
> +#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)

I've had this in -mm for a couple of weeks now but rmk points out that it's
rather silly.  Because if you have CONFIG_HOTPLUG=y, CONFIG_NET=n then the
kernel cannot deliver hotplug events to userspace..

So perhaps CONFIG_HOTPLUG should depend upon CONFIG_NET or, better,
CONFIG_NETLINK.

Dunno.  I left this in Greg's lap, but he's hiding.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/