Re: [PATCH 2/3] swsusp i386 mark special saveable/unsaveable pages

[Nigel Cunningham]

Hi.

On Wednesday 12 April 2006 12:38, Shaohua Li wrote:
> @@ -1400,6 +1401,111 @@ static void set_mca_bus(int x)
>  static void set_mca_bus(int x) { }
>  #endif
>
> +#ifdef CONFIG_SOFTWARE_SUSPEND
> +static void __init mark_nosave_page_range(unsigned long start, unsigned
> long end) +{
> +	struct page *page;
> +	while (start <= end) {

Should this be start < end? (End is usually the first byte of the next zone 
IIUC).

> +		page = pfn_to_page(start);
> +		SetPageNosave(page);
> +		start++;
> +	}
> +}
> +
> +static void __init e820_nosave_reserved_pages(void)
> +{
> +	int i;

Regards,

Nigel

Attachment: pgp00000.pgp
Description: PGP signature