Re: Implement lookup_swap_cache for migration entries

From: Andrew Morton
Date: Fri Apr 14 2006 - 15:13:51 EST


Christoph Lameter <clameter@xxxxxxx> wrote:
>
> On Fri, 14 Apr 2006, Andrew Morton wrote:
>
> > > @@ -305,6 +306,12 @@ struct page * lookup_swap_cache(swp_entr
> > > {
> > > struct page *page;
> > >
> > > + if (is_migration_entry(entry)) {
> > > + page = migration_entry_to_page(entry);
> > > + get_page(page);
> > > + return page;
> > > + }
> >
> > What locking ensures that the state of `entry' remains unaltered across the
> > is_migration_entry() and migration_entry_to_page() calls?
>
> entry is a variable passed by value to the function.

Sigh.

What locking ensures that the state of the page referred to by `entry' is
stable?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/