Re: [PATCH 6/6] Break out memory initialisation code from page_alloc.cto mem_init.c

[Mel Gorman]

On Tue, 11 Apr 2006, Nick Piggin wrote:

> Mel Gorman wrote:
> > page_alloc.c contains a large amount of memory initialisation code. This 
> > patch
> > breaks out the initialisation code to a separate file to make page_alloc.c
> > a bit easier to read.
>
> Seems like a very good idea to me.

If there is interest in treating this separetly, it can be broken out as a 
standalone patch. In this form, it depends on the first patch from the 
set.

> > +/*
> > + * mm/mem_init.c
> > + * Initialises the architecture independant view of memory. pgdats, zones, 
> > etc
> > + *
> > + *  Copyright (C) 1991, 1992, 1993, 1994  Linus Torvalds
> > + *  Swap reorganised 29.12.95, Stephen Tweedie
> > + *  Support of BIGMEM added by Gerhard Wichert, Siemens AG, July 1999
> > + *  Reshaped it to be a zoned allocator, Ingo Molnar, Red Hat, 1999
> > + *  Discontiguous memory support, Kanoj Sarcar, SGI, Nov 1999
> > + *  Zone balancing, Kanoj Sarcar, SGI, Jan 2000
> > + *  Per cpu hot/cold page lists, bulk allocation, Martin J. Bligh, Sept 
> > 2002
> > + *	(lots of bits borrowed from Ingo Molnar & Andrew Morton)
> > + *  Arch-independant zone size and hole calculation, Mel Gorman, IBM, Apr 
> > 2006
> > + *	(lots of bits taken from architecture code)
> > + */
>
> Maybe drop the duplicated changelog? (just retain copyrights I guess)

Makes sense.

+ *  Copyright (C) 1991, 1992, 1993, 1994  Linus Torvalds
+ *  Copyright (C) 1995, Stephen Tweedie
+ *  Copyright (C) July 1999, Gerhard Wichert, Siemens AG
+ *  Copyright (C) 1999, Ingo Molnar, Red Hat
+ *  Copyright (C) 1999, 2000, Kanoj Sarcar, SGI
+ *  Copyright (C) Sept 2000, Martin J. Bligh
+ *     (lots of bits borrowed from Ingo Molnar & Andrew Morton)
+ *  Copyright (C) Apr 2006, Mel Gorman, IBM
+ *     (lots of bits taken from architecture-specific code)


--
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/