Re: 2.6.17-rc1-mm1
From: Russell King
Date: Thu Apr 06 2006 - 06:22:30 EST
On Wed, Apr 05, 2006 at 04:01:08PM -0600, Bjorn Helgaas wrote:
> [PATCH] vgacon: make VGA_MAP_MEM take size, remove extra use
Ah, seems to be what I just suggested...
> @@ -1020,14 +1019,14 @@
> char *charmap;
>
> if (vga_video_type != VIDEO_TYPE_EGAM) {
> - charmap = (char *) VGA_MAP_MEM(colourmap);
> + charmap = (char *) VGA_MAP_MEM(colourmap, 0);
Don't like this though - can't we pass a real size here rather than zero?
There seems to be several clues as to the maximum size:
#define cmapsz 8192
if (!vga_font_is_default)
charmap += 4 * cmapsz;
charmap += 2 * cmapsz;
for (i = 0; i < cmapsz; i++)
vga_writeb(arg[i], charmap + i);
so that's about 7 * cmapsz - call that 8 for completeness, which is 64K.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/