Re: [patch 03/26] sysfs: zero terminate sysfs write buffers (CVE-2006-1055)

[Greg KH]

On Wed, Apr 05, 2006 at 03:58:15PM -0400, Valdis.Kletnieks@xxxxxx wrote:
> On Wed, 05 Apr 2006 16:39:57 BST, Al Viro said:
> 
> > How about _NOT_ using sysfs and just having ->read()/->write() on a file in fs
> > of your own?  ~20 lines for all of it, not counting #include...
> 
> Great.  Instead of everybody using the same piece-of-manure sysfs interface,
> each driver carries around its 20 lines to implement read() and write() in
> subtly buggy and incompatible ways.
> 
> % grep nodev /proc/filesystems | wc -l
> 19
> 
> That's fsck'ing insane already.

What is insane is using sysfs in ways it was not designed to do so.  The
color map is clearly not a "single, small value".  I have recommended
that the binary file in sysfs be used instead, as that is a designed
solution, but the authors do not want to do so for some odd reason.

So, we have a number of proposed solutions:
	- custom fs
	- binary sysfs file
	- configfs
and yet, people still complain...

bleah.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/