Re: [2.6.16 PATCH] Filessytem Events Reporter V2

From: Carlos Silva
Date: Wed Apr 05 2006 - 12:14:40 EST


On Wed, 2006-04-05 at 21:21 +0800, Yi Yang wrote:
> <snip>
> +static void cleanup_dead_listener(listener * x)
> +{
> + pid_filter * p = NULL, * pq = NULL;
> + uid_filter * u = NULL, * uq = NULL;
> + gid_filter * g = NULL, * gq = NULL;
> +
> + if (p == NULL)
> + return;
> <snip>

I think you ment "if (x == NULL)" here. Otherwise, the condition will always be true.
btw, I'm not reviewing your code, just stumbled across this while reading it.

Attachment: signature.asc
Description: This is a digitally signed message part