Re: 2.6.17-rc1-mm1

From: Andrew Morton
Date: Wed Apr 05 2006 - 03:30:35 EST


Roger Luethi <rl@xxxxxxxxxxx> wrote:
>
> Any suggestions for an elegant solution?

Move the locking down lower, so it just locks the stuff which needs locking?

It all depends on what the lock's role is, and so often that's a big secret.

If the intention is to prevent concurrent execution of mdio_read()
(reasonable) and we really need that 1 msec delay between writing the
registers and reading back the result then we're somewhat screwed. Either
use a sleeping lock to protect that hardware state or go back to using
udelay().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/