[patch 4/9] s390: Wrong return codes in cio_ignore_proc_init().

From: Martin Schwidefsky
Date: Mon Apr 03 2006 - 13:22:47 EST


From: Cornelia Huck <cornelia.huck@xxxxxxxxxx>

[patch 4/9] s390: Wrong return codes in cio_ignore_proc_init().

cio_ignore_proc_init() returns 1 in case of success and 0 in case
of failure. The caller tests for != 0, so better return 0 in case of
success and -ENOENT in case of failure.

Signed-off-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
---

drivers/s390/cio/blacklist.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff -urpN linux-2.6/drivers/s390/cio/blacklist.c linux-2.6-patched/drivers/s390/cio/blacklist.c
--- linux-2.6/drivers/s390/cio/blacklist.c 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6-patched/drivers/s390/cio/blacklist.c 2006-04-03 18:46:37.000000000 +0200
@@ -414,11 +414,11 @@ cio_ignore_proc_init (void)
entry = create_proc_entry ("cio_ignore", S_IFREG | S_IRUGO | S_IWUSR,
&proc_root);
if (!entry)
- return 0;
+ return -ENOENT;

entry->proc_fops = &cio_ignore_proc_fops;

- return 1;
+ return 0;
}

__initcall (cio_ignore_proc_init);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/