Re: [PATCH] unify PFN_* macros

[Dave Hansen]

On Mon, 2006-04-03 at 13:49 +0100, Ralf Baechle wrote:
> On Thu, Mar 23, 2006 at 08:24:59AM -0800, Dave Hansen wrote:
> 
> > Just about every architecture defines some macros to do operations on
> > pfns.  They're all virtually identical.  This patch consolidates all
> > of them.
> > 
> > One minor glitch is that at least i386 uses them in a very skeletal
> > header file.  To keep away from #include dependency hell, I stuck
> > the new definitions in a new, isolated header.
> > 
> > Of all of the implementations, sh64 is the only one that varied by a
> > bit.  It used some masks to ensure that any sign-extension got
> > ripped away before the arithmetic is done.  This has been posted to
> > that sh64 maintainers and the development list.
> > 
> > Compiles on x86, x86_64, ia64 and ppc64.
> 
> Ehhh...  Looks at this patch I wonder if you actually read the MIPS bits
> before submitting it:
> 
>  o replaces PFN_ALIGN with PAGE_ALIGN

Yeah, that is blatantly wrong.  I have no idea what I was thinking
there.  

>  o replaces the IP27 definition of PFN_ALIGN with a different one.

That was part of the idea :)  Was there something special about that
implementation?

> How about posting such stuff to linux-arch?  No sane person follows l-k.

I was under the impression that linux-arch wasn't the kind of list which
is supposed to posted to by "normal" people.  I was scolded once for
cc'ing it.  If instructed so, I'd be happy to post there in the future.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/