[PATCH 4/4] UEAGLE : memory leack fix

From: matthieu castet
Date: Sun Apr 02 2006 - 12:41:14 EST


Hi,

this patch fix leak of memory allocated to intr if allocation of sc->urb_int fails.
Found by the Coverity checker.

Signed-off-by: Duncan Sands <baldrick@xxxxxxx>
Signed-off-by: Matthieu CASTET <castet.matthieu@xxxxxxx>


Index: ueagle-atm.c
===================================================================
--- ueagle-atm.c (révision 266)
+++ ueagle-atm.c (révision 267)
@@ -1376,7 +1376,7 @@
if (ret < 0) {
uea_err(INS_TO_USBDEV(sc),
"urb submition failed with error %d\n", ret);
- goto err1;
+ goto err;
}

sc->kthread = kthread_run(uea_kthread, sc, "ueagle-atm");
@@ -1390,10 +1390,10 @@

err2:
usb_kill_urb(sc->urb_int);
-err1:
- kfree(intr);
err:
usb_free_urb(sc->urb_int);
+ sc->urb_int = NULL;
+ kfree(intr);
uea_leaves(INS_TO_USBDEV(sc));
return -ENOMEM;
}